Skip to content

Conversation

@fmayer
Copy link
Contributor

@fmayer fmayer commented Nov 21, 2024

No description provided.

Created using spr 1.3.4
@fmayer fmayer requested a review from a team as a code owner November 21, 2024 00:38
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Nov 21, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 21, 2024

@llvm/pr-subscribers-libcxx

Author: Florian Mayer (fmayer)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/117085.diff

1 Files Affected:

  • (modified) libcxx/test/std/experimental/simd/simd.class/simd_copy.pass.cpp (+1)
diff --git a/libcxx/test/std/experimental/simd/simd.class/simd_copy.pass.cpp b/libcxx/test/std/experimental/simd/simd.class/simd_copy.pass.cpp
index 7d91ca0eada1d3..340d69f51a4be4 100644
--- a/libcxx/test/std/experimental/simd/simd.class/simd_copy.pass.cpp
+++ b/libcxx/test/std/experimental/simd/simd.class/simd_copy.pass.cpp
@@ -7,6 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++03, c++11, c++14
+// UNSUPPORTED: hwasan
 
 // Older versions of clang may encounter a backend error (see 0295c2ad):
 //   Pass-by-value arguments with alignment greater than register width are not supported.

//===----------------------------------------------------------------------===//

// UNSUPPORTED: c++03, c++11, c++14
// UNSUPPORTED: hwasan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to instead use REQUIRES: long_tests since this isn't a fundamental limitation of hwasan but merely a matter of timing out on your specific builder (I assume?).

@fmayer fmayer closed this Dec 11, 2024
@ldionne ldionne deleted the users/fmayer/spr/disable-test-that-times-out-on-hwasan branch December 11, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants